Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve Slack & nutripatrol notifier #1343

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

raphael0202
Copy link
Collaborator

  • don't publish anymore on Slack public channel
  • specify the reason when pushing to nutripatrol
  • remove the likelihood key

- don't publish anymore on Slack public channel
- specify the reason when pushing to nutripatrol
- remove the likelihood key
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a9244f9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
robotoff/notifier.py 85.18% 4 Missing ⚠️
robotoff/app/api.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1343   +/-   ##
=======================================
  Coverage        ?   57.33%           
=======================================
  Files           ?       79           
  Lines           ?     7848           
  Branches        ?        0           
=======================================
  Hits            ?     4500           
  Misses          ?     3348           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 merged commit 076fb11 into main May 15, 2024
10 checks passed
@raphael0202 raphael0202 deleted the improve-notifier branch May 15, 2024 15:14
@raphael0202 raphael0202 restored the improve-notifier branch October 28, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant